Add Sendable conformance to various structs and enums
#894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `EthereumAddress` and its nested `AddressType` enum to conform to `Sendable`. - Modified `BlockNumber` enum to conform to `Sendable`. - Added `Sendable` conformance to `CodableTransaction` struct. - Updated `TransactionType` enum and `AbstractEnvelope` protocol to conform to `Sendable`. - Added `Sendable` conformance to `AccessListEntry` struct. - Modified `TransactionMetadata` struct to conform to `Sendable`.
|
Seems like this remote test constantly fails on this PR.
Ps: you can run pipeline on your fork, AFAIK all the gateway keys are stored in plain. |
|
@yaroslavyaroslav I checked out to previous commit 11f9c4a and it is still failing. I don't see my changes break it. This test is actually using a live address https://etherscan.io/address/0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B I believe this is a completely separated issue to fix. |
yaroslavyaroslav
merged commit 4ea879b
into
web3swift-team:develop
1 of 3 checks passed
|
True, thank you for your contribution, I'll release it asap |
|
@yaroslavyaroslav I would appreciate the release. |
|
Done. 3.3.1 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EthereumAddressand its nestedAddressTypeenum to conform toSendable.BlockNumberenum to conform toSendable.Sendableconformance toCodableTransactionstruct.TransactionTypeenum andAbstractEnvelopeprotocol to conform toSendable.Sendableconformance toAccessListEntrystruct.TransactionMetadatastruct to conform toSendable.Test Data or Screenshots